[CI] Add static checks in github action and sanitizers for unit tests #2725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: czm <[email protected]>
Signed-off-by: czm <[email protected]>
YunhuiChen
approved these changes
Sep 4, 2023
wu-hanqing
reviewed
Sep 8, 2023
|
cicheck |
Signed-off-by: czm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #2570
Problem Summary: Use github action to do some static checks and code security tests on the code in the curve warehouse
What is changed and how it works?
What's Changed: Github action workflow, .bazelrc, ut.sh and util/ut_in_image.sh
How it Works: By adding some jobs in github action workflow, cppcheck and cpplint is now automatically performed on push and pull request, and results are published to action files.
The .bazelrc is changed to add building configs for enabling ASan, MSan and UBSan. Then running ut.sh with "--sanitizer [mode]" will use corresponding config to build curve with sanitizers and run tests (specifically, mode=1 for ASan and mode=2 for MSan and UBSan).
Side effects(Breaking backward compatibility? Performance regression?): Running tests with sanitizers may be ~2x-4x slower.
Check List